Warning, /geant4/source/geometry/solids/CSG/History is written in an unsupported language. File is not indexed.
0001 # Category geom-csg History
0002
0003 See `CONTRIBUTING.rst` for details of **required** info/format for each entry,
0004 which **must** added in reverse chronological order (newest at the top).
0005 It must **not** be used as a substitute for writing good git commit messages!
0006
0007 -------------------------------------------------------------------------------
0008
0009 ## 2024-05-29 Evgueni Tcherniaev (geom-csg-V11-02-03)
0010 - Added new methods GetNumOfConstituents() and IsFaceted().
0011
0012 ## 2024-04-02 Gabriele Cosmo (geom-csg-V11-02-02)
0013 - Applied trivial clang-tidy fixes to G4CSGSolid, i.e. use of 'override'.
0014
0015 ## 2023-12-22 Evgueni Tcherniaev (geom-csg-V11-02-01)
0016 - Use GetThetaCosPhi() and GetThetaSinPhi() in wrapper method G4UTrap::GetVertices(),
0017 this fixes the problem with trapezoid arised in CMSSW after migration to VecGeom 1.2.6
0018
0019 ## 2023-12-18 Gabriele Cosmo (geom-csg-V11-02-00)
0020 - Fixed typo in wrapper method G4UTrap::SetAllParameters(), setter used in
0021 parameterisation of shape dimensions.
0022
0023 ## 2023-05-10 Gabriele Cosmo (geom-csg-V11-01-01)
0024 - Applied clang-tidy fixes (readability, modernization, performance, ...).
0025
0026 ## 2023-03-23 Jonas Hahnfeld (geom-csg-V11-01-00)
0027 - G4UTrap: Fixed constructor for Right Angular Wedge with VecGeom
0028
0029 ## 2022-11-10 Gabriele Cosmo (geom-csg-V11-00-02)
0030 - Fixed compilation warnings for implicit type conversions on macOS/XCode 14.1.
0031
0032 ## 2022-09-19 Ben Morgan (geom-csg-V11-00-01)
0033 - G4Cons: define private enums within unnamed namespace, to overcome
0034 C++ ODR (One Definition Rule) violation.
0035
0036 ## 2021-12-10 Ben Morgan (geom-csg-V11-00-00)
0037 - Change to new Markdown History format
0038
0039 ---
0040
0041 # History entries prior to 11.0
0042
0043 November 24, 2021 G.Cosmo geom-csg-V10-07-06
0044 - Corrected typo in G4UPara::GetXHalfLength().
0045 Addressing problem report #2446.
0046
0047 November 01, 2021 E.Tcherniaev geom-csg-V10-07-05
0048 - Revision of G4UTrap:
0049 o List of accessors and modifiers made consistent with G4Trap
0050 o Implemented check of parameters similar to G4Trap
0051
0052 August 31, 2021 B.Morgan geom-csg-V10-07-04
0053 - Remove old Get-er methods that simply forward to the new main Get-er
0054 methods
0055
0056 May 18, 2021 J.Apostolakis geom-csg-V10-07-03
0057 - Added method to enable simpler conversion of G4 solids to VecGeom:
0058 o G4Trap: added methods to calculate Phi & Theta
0059 o G4Para: added methods to calculate original alpha, theta, phi
0060
0061 May 17, 2021 E.Tcherniaev geom-csg-V10-07-02
0062 - Bux fix in G4Sphere::GetSurfaceArea()
0063 - G4Sphere::GetCubicVolume() moved to source
0064 - Revised G4Sphere::GetPointOnSurface()
0065
0066 March 30, 2021 B.Morgan geom-csg-V10-07-01
0067 - Migrate sources.cmake to modular build API
0068
0069 February 1, 2021 G.Cosmo geom-csg-V10-07-00
0070 - G4Trap, G4Para: removed spurious character in printout in StreamInfo().
0071 Addressed problem report #2318.
0072
0073 November 12, 2020 E.Tcherniaev geom-csg-V10-06-05
0074 - G4Sphere::InitializeThetaTrigonometry(): tan() replaced with sin()/cos(),
0075 it addresses problem report #2289
0076
0077 October 08, 2020 E.Tcherniaev geom-csg-V10-06-04
0078 - G4Box: Migration to G4QuickRand in GetPointOnSurface();
0079 - G4Trd: Added two precalculated values fHx, fHy for fast calculation
0080 of lateral areas; Revision of GetPointOnSurface();
0081 - G4Trap: Added array fAreas[6] with precalculated face areas;
0082 Added SetCachedValues() method; Revision of GetPointOnSurface();
0083 - G4Tubs: Revision of GetPointOnSurface();
0084 - G4CSGSolid: Explicit implementation of G4RandomRadiusInRing(rmin,rmax)
0085 based on G4QuickRand
0086
0087 October 06, 2020 E.Tcherniaev geom-csg-V10-06-03
0088 - Improved G4CutTubs:
0089 o Implemented GetCubicVolume(), GetSurfaceArea();
0090 o Reimplemented GetPointOnSurface(), it's now faster and uniform;
0091 o Reimplemented IsCrossingCutPlanes(), it now reports a problem
0092 only in case if cut planes are crossing inside the lateral surface;
0093 o Removed GetMaxMinZ() as obsolete;
0094
0095 April 30, 2020 G.Cosmo geom-csg-V10-06-02
0096 - Adopt new convention for location of headers in VecGeom for all wrappers.
0097
0098 April 09, 2020 E.Tcherniaev geom-csg-V10-06-01
0099 - G4Trap.cc: fixed calculation of normal for points on edge in
0100 SurfaceNormal(), improved code for Inside().
0101 - testG4Sphere.cc: removed obsolete code for testing CalculateExtent().
0102
0103 December 10, 2019 B.Morgan geom-csg-V10-06-00
0104 - Cleanup CMake build, removing obsolete granular library options and
0105 explicit include_directories.
0106
0107 August 23, 2019 G.Cosmo geom-csg-V10-05-05
0108 - Minor c++11 revision and headers cleanup.
0109 - Use pre-increment wherever possible.
0110
0111 July 1, 2019 G.Cosmo geom-csg-V10-05-04
0112 - G4CutTubs: fixed minor Coverity defects for non initialised data in
0113 constructors.
0114
0115 May 31, 2019 J.Apostolakis geom-csg-V10-05-03
0116 - G4Tubs: Fixed normal from DistanceToOut (to be unit vector) for abnormal
0117 exit points. Added inverse-Rmax and -Rmin as data members.
0118
0119 May 31, 2019 G.Cosmo geom-csg-V10-05-02
0120 - More reuse of pre-calculated values for sin() and cos() in G4Tubs,
0121 G4Cons, G4CutTubs, G4Sphere.
0122
0123 May 28, 2019 J.Apostolakis geom-csg-V10-05-01
0124 - G4Tubs: reused pre-calculated values instead of using std::cos(), std::sin().
0125
0126 May 14, 2019 B.Morgan geom-csg-V10-05-00
0127 - Add inclusion of new G4GeomTypes.hh header to those headers allowing
0128 VecGeom replacement.
0129 - See also geommng-10-05-05
0130
0131 November 13, 2018 E.Tcherniaev geom-csg-V10-04-07
0132 - G4Orb: improved check if point is too far in DistanceToIn(p,v).
0133 - G4Torus: added check if point is too far in DistanceToIn(p,v).
0134 Addressing problem report #2100.
0135
0136 November 12, 2018 E.Tcherniaev geom-csg-V10-04-06
0137 - G4Cons: fix in GetPointOnSurface() when sampling on inner and outer
0138 conical surfaces.
0139
0140 September 13, 2018 G.Cosmo geom-csg-V10-04-05
0141 - G4UTorus: removed leftover use of UVector3 and replaced with U3Vector.
0142
0143 August 10, 2018 A.Gheata geom-csg-V10-04-04
0144 - Make G4UTrd wrapper inheriting from vecgeom::GenericUnplacedTrd,
0145 following the latest changes in VecGeom.
0146
0147 May 7, 2018 G.Cosmo geom-csg-V10-04-03
0148 - Make G4UCons wrapper inheriting from vecgeom::GenericUnplacedCone,
0149 following the latest changes in VecGeom.
0150
0151 April 11, 2018 G.Cosmo geom-csg-V10-04-02
0152 - G4Box: simplified and optimised calculation of normal in method
0153 DistanceToOut(p,v,..). (E.Tcherniaev)
0154 - Replaced USOLIDS_LIBRARIES with VECGEOM_LIBRARIES in sources.cmake.
0155
0156 February 5, 2018 G.Cosmo geom-csg-V10-04-01
0157 - Correction in G4UPara::ComputeDimensions() to add explicit cast for the
0158 solid type to parameterise.
0159
0160 December 11, 2017 E.Tcherniaev geom-csg-V10-04-00
0161 - Fixed typo in G4Trd::GetPointOnSurface() for the area settings.
0162
0163 November 22, 2017 G.Cosmo geom-csg-V10-03-38
0164 - Fix in SurfaceNormal() for G4Trap, G4Para, G4Trd to assure explicit
0165 counting of the surfaces where the point is placed on edges.
0166
0167 October 20, 2017 G.Cosmo geom-csg-V10-03-37
0168 - Removed redundant overloaded implementation for StreamInfo() in G4UBox
0169 wrapper.
0170
0171 October 9, 2017 G.Cosmo geom-csg-V10-03-36
0172 - Enabled adapter for G4UTorus wrapper, according to migration done in
0173 VecGeom for UnplacedTorus2.
0174
0175 September 1, 2017 E.Tcherniaev geom-csg-V10-03-35
0176 - G4Trap: use specialization (fTrapType 3) for traps that could be also
0177 defined as G4Trd, where isosceles trapeziod is in the XY section, instead
0178 of XZ (faces at Xmin/Xmax symmetrical and have Z-component of normals equal
0179 to zero). Factorised code with case statements for the different
0180 specialisations.
0181
0182 August 14, 2017 E.Tcherniaev geom-csg-V10-03-34
0183 - Reviewed implementation of G4Orb, made more compact and performant.
0184
0185 July 20, 2017 E.Tcherniaev geom-csg-V10-03-33, 32
0186 - Use G4RandomRadiusInRing() in G4CSGSolid::GetRadiusInRing().
0187
0188 July 19, 2017 G.Cosmo geom-csg-V10-03-31
0189 - Enabled adapter also in G4USphere wrapper.
0190
0191 July 13, 2017 E.Tcherniaev geom-csg-V10-03-30
0192 - Improved calculation of bounding box in G4CutTubs and related wrapper.
0193
0194 July 11, 2017 G.Cosmo geom-csg-V10-03-29
0195 - Added G4UPara wrapper for enabling VecGeom Parallelepiped shape.
0196 - Removed inheritance from G4Tubs for G4CutTubs.
0197
0198 July 10, 2017 G.Cosmo geom-csg-V10-03-28
0199 - Added G4UCutTubs wrapper for enabling VecGeom CutTube shape.
0200 - Removed clone class G4OTubs no longer necessary and make G4CutTubs
0201 directly inheriting (temporary) from G4Tubs.
0202
0203 July 4, 2017 E.Tcherniaev geom-csg-V10-03-27
0204 - G4Box: minor optimisation in DistanceToOut(p).
0205 - G4Para: optimisation in Inside(), DistanceToIn/Out(p), use std::abs(xx)
0206 in place of std::max(xx,-xx).
0207
0208 June 26, 2017 E.Tcherniaev geom-csg-V10-03-26
0209 - G4Trd: allow Dx and Dy parameters be equal to zero where appropriate.
0210
0211 June 15, 2017 G.Cosmo geom-csg-V10-03-25
0212 - Enabled adapter also in G4UCons wrapper.
0213
0214 June 6, 2017 G.Cosmo geom-csg-V10-03-24
0215 - Enable adapter for VecGeom shapes in G4U* wrappers for: box, trap, trd,
0216 tubs and orb. From now on, wrappers depends directly on VecGeom shapes
0217 implementation. USolids API is deprecated and no longer supported.
0218
0219 June 1, 2017 E.Tcherniaev geom-csg-V10-03-23
0220 - G4Trap: added more strict condition for trap definition in case when
0221 YZ section is a rectangle.
0222
0223 May 31, 2017 E.Tcherniaev geom-csg-V10-03-22
0224 - Reviewed implementation of G4Para, made more compact and performant.
0225 - G4Trap: fix in the calculation of side planes.
0226 - G4Trd: speedup further DistanceToIn(p,v) making it similar to the
0227 implementation in G4Para. Fix in the calculation of side planes.
0228
0229 May 29, 2017 E.Tcherniaev geom-csg-V10-03-21
0230 - G4Trd: fixed issue in GetPointOnSurface().
0231 - Updated unit tests.
0232
0233 May 26, 2017 E.Tcherniaev geom-csg-V10-03-20
0234 - Reviewed implementation of G4Trd, made more compact and performant.
0235 Removed obsolete method CheckAndSetAllParameters().
0236
0237 May 24, 2017 G.Cosmo geom-csg-V10-03-19
0238 - Renamed ambiguous name Extent() in all solids and G4U* wrappers to
0239 BoundingLimits(). Change required in order to avoid signature conflict
0240 with VecGeom in G4U* wrappers.
0241 Requires tag geommng-V10-03-16.
0242
0243 May 23, 2017 E.Tcherniaev geom-csg-V10-03-18
0244 - G4Trap: some code improvements.. use std::copysign(); replace division
0245 with multiplication by inverse value; code formatting.
0246
0247 May 21, 2017 E.Tcherniaev geom-csg-V10-03-17
0248 - Fix in G4CutTubs::Inside() for case where inside points were concidered
0249 as points on surface. Addressing problem report #1973.
0250
0251 May 8, 2017 E.Tcherniaev geom-csg-V10-03-16
0252 - G4Box: use std::copysign() to improve performance on Linux.
0253 Some code formatting.
0254
0255 May 4, 2017 E.Tcherniaev geom-csg-V10-03-15
0256 - G4Trap: fixed cases of division by zero reported by testing.
0257
0258 May 1, 2017 E.Tcherniaev geom-csg-V10-03-14
0259 - Reviewed implementation of G4Trap, made more compact and performant.
0260
0261 April 18, 2017 E.Tchernieav geom-csg-V10-03-13, 12
0262 - Reviewed implementation of G4Box, made more compact and performant.
0263
0264 April 11, 2017 G.Cosmo geom-csg-V10-03-11, 10, 09
0265 - Added accessor for radial tolerance also in G4UOrb wrapper.
0266
0267 April 7, 2017 G.Cosmo geom-csg-V10-03-08
0268 - Added accessor to G4Orb for retrieving cached max radius tolerance.
0269 - Added private members halfCarTolerance and fTrapType to G4Trap (E.Tcherniaev).
0270
0271 April 1, 2017 E.Tcherniaev geom-csg-V10-03-07
0272 - G4Trap: Fix in GetPointOnSurface(), the method could generate points laying
0273 outside the surface. Added private method GetVertices(), calculating vertices
0274 of the trap from its side planes; removed private methods GetFaceArea() and
0275 GetPointOnPlane(). Improved GetCubicVolume() and GetSurfaceArea();
0276 calculation of the volume and surface area is now done by using vertices
0277 calculated by GetVertices(). Improved/simplified other methods: StreamInfo(),
0278 MakePlanes(), MakePlanes(pt), Extent() and CalculateExtent().
0279
0280 March 16, 2017 E.Tcherniaev geom-csg-V10-03-06, 05, 04
0281 - G4Trap: modified computation of side planes; bounding box/envelope
0282 are computed directly from side planes. Added CheckParameters() and
0283 MakePlanes(pt), simplified constructors and SetAllParameters().
0284 - G4UTrap: bounding box/envelope are computed directly from side planes
0285 as for G4Trap. Increased tolerance in the check of consistency of
0286 bounding boxes in Extent().
0287
0288 March 2, 2017 E.Tcherniaev geom-csg-V10-03-03
0289 - Fixed possible rounding off error in calculation of 'astep' (max angle
0290 for one step) in CalculateExtent() for G4Cons, G4Tubsm, G4CutTubs
0291 and related USolids wrappers.
0292 - Increased tolerance in the check of consistency of bounding boxes in
0293 G4UTrap::Extent().
0294
0295 February 22, 2017 E.Tcherniaev geom-csg-V10-03-02
0296 - Fix in GetCubicVolume() and GetSurfaceArea() for G4CutTubs, to make
0297 use of the cached values. Addressing problem report #1943.
0298
0299 February 2, 2017 G.Cosmo geom-csg-V10-03-01
0300 - Removed redundant code/checks in G4Orb::SurfaceNormal().
0301
0302 December 20, 2016 H.Burkhardt, E.Tcherniaev geom-csg-V10-03-00
0303 - Use radius differences and hypot to improve precision in G4Torus.
0304 Addressing problem report #1931.
0305
0306 November 18, 2016 E.Tcherniaev geom-csg-V10-02-19
0307 - Added consistency checks for extent computation in USolids wrappers.
0308
0309 November 7, 2016 E.Tcherniaev geom-csg-V10-02-18
0310 - Added optional debug flag G4BBOX_EXTENT in GNUMake build to compare
0311 extent calculation by simply using bounding-box.
0312
0313 November 3, 2016 E.Tcherniaev geom-csg-V10-02-17
0314 - Disabled check for intersection of cut planes in G4CutTubs constructor,
0315 as too strict and not necessary. Addressing problem report #1887.
0316
0317 October 31, 2016 E.Tcherniaev geom-csg-V10-02-16
0318 - Re-implemented CalculateExtent() to make use of G4BoundingEnvelope and
0319 removed no-longer used method CreateRotatedVertices() in G4Sphere, G4OTubs,
0320 G4Torus, G4Orb, and related USolids wrappers.
0321 - Use G4GeomTools::DiskExtent() for calculation of bounding box in Extent()
0322 for G4Tubs, G4Cons and related USolids wrappers.
0323 - Use G4RandFlat instead of RandFlat.
0324
0325 October 5, 2016 E.Tcherniaev geom-csg-V10-02-15
0326 - G4Cons, G4UCons: re-implemented CalculateExtent() to make use of
0327 G4BoundingEnvelope; removed no-longer used method CreateRotatedVertices().
0328 - G4Tubs, G4UTubs: revised implementation of CalculateExtent() to avoid use
0329 of addresses to vectors elements. Attempting fix for reported Coverity defect.
0330
0331 September 27, 2016 G.Cosmo geom-csg-V10-02-14
0332 - Reduced number of segments in G4Tubs and G4UTubs for CalculateExtent() from
0333 48 to 24.
0334
0335 September 27, 2016 E.Tcherniaev geom-csg-V10-02-13
0336 - Corrected vertices order for definition of bounding envelope in
0337 G4Trap, G4UTrap and G4Para.
0338
0339 September 26, 2016 E.Tcherniaev geom-csg-V10-02-12
0340 - More corrections in G4Trap and G4UTrap in Extent() for use of 'alpha'
0341 accessors.
0342
0343 September 26, 2016 G.Cosmo, E.Tcherniaev geom-csg-V10-02-11, 10
0344 - Re-implemented CalculateExtent() of G4Para, G4Trd, G4Trap to make use of
0345 G4BoundingEnvelope; removed no-longer used method CreateRotatedVertices()
0346 implementation. Use same algorithm in G4UTrd and G4UTrap wrappers.
0347 - Fix in G4UBox in computation of the extent for problem introduced in
0348 previous tags.
0349
0350 September 22, 2016 E.Tcherniaev geom-csg-V10-02-09, 08, 07
0351 - G4Box, G4Tubs: added Extent() method and checks on extent validity.
0352 - G4UBox, G4UTubs: use same CalculateExtent() technique as for G4Box
0353 and G4Tubs.
0354
0355 August 30, 2016 E.Tcherniaev geom-csg-V10-02-06
0356 - G4Tubs: added construction of bounding envelope in CalculateExtent().
0357
0358 August 29, 2016 G.Cosmo geom-csg-V10-02-05
0359 - Removed no-longer used method CreateRotatedVertices() implementation in
0360 G4Box and G4Tubs. Simplified code in G4Tubs::CalculateExtent().
0361
0362 August 26, 2016 E.Tcherniaev
0363 - Re-implemented CalculateExtent() of G4Box and G4Tubs to make use of
0364 G4BoundingEnvelope. Implemented bounding-box in G4Tubs to take into
0365 consideration cuts in phi.
0366
0367 May 20, 2016 G.Cosmo geom-csg-V10-02-04
0368 - Moved accessors and modifiers in USolids wrappers to be not inlined.
0369 Required modification in order to allow correct dispatching to VecGeom
0370 types.
0371
0372 April 15, 2016 G.Cosmo geom-csg-V10-02-03
0373 - Added flag in USolids wrappers for partial use of USolids/VecGeom types.
0374
0375 April 5, 2016 J.Allison geom-csg-V10-02-02
0376 - G4Orb.cc: Fixed typo in G4Exception message.
0377
0378 March 31, 2016 G.Cosmo geom-csg-V10-02-01
0379 - Added overloaded CreatePolyhedron() method to USolids wrappers.
0380 It is now possible to visualize supported VecGeom shapes.
0381
0382 March 10, 2016 G.Cosmo geom-csg-V10-02-00
0383 - Added overloaded GetEntityType() method to USolids wrappers.
0384
0385 October 23, 2015 G.Cosmo geom-csg-V10-01-10
0386 - Fixed Coverity defect in G4CutTubs::GetMaxMinZ().
0387
0388 October 22, 2015 G.Cosmo geom-csg-V10-01-09
0389 - Reintroduced check, now corrected, in G4Sphere::DistanceToIn(p,v) for
0390 concave Theta and point located on the origin. Also make proper use of
0391 radial tolerance in DistanceToOut(p,v).
0392
0393 October 7, 2015 G.Cosmo geom-csg-V10-01-08
0394 - Protected compilation of USolid wrappers with G4GEOM_USE_USOLIDS flag.
0395 - Restored G4Sphere code to tag "geom-csg-V10-01-06".
0396
0397 September 3, 2015 T.Nikitina geom-csg-V10-01-07
0398 - Fix in DistanceToIn(p,v) and DistanceToOut(p,v) for G4Sphere with concave
0399 Theta. Follow-up of fix previously introduced to G4Sphere for point (0,0,0).
0400 - Updated unit test for sphere.
0401
0402 September 1, 2015 G.Cosmo geom-csg-V10-01-06
0403 - Corrected conditional compilation flag in G4UTorus.cc.
0404
0405 August 31, 2015 G.Cosmo geom-csg-V10-01-05
0406 - Added USolids/VecGeom wrapper for G4Torus (G.Lima/FNAL).
0407 Activated only for external USolids/VecGeom installation.
0408
0409 May 20, 2015 T.Nikitina geom-csg-V10-01-04
0410 - Fixed DistanceToOut(p) and Inside(p) in G4Sphere for sphere cut in theta
0411 for point (0,0,0) and for cases when Start/End angle have not to be taken
0412 in account (STheta==0 || eTheta==pi).
0413 Added corresponding test cases to unit test for testG4Sphere.
0414 Fix triggered by analysing setup provided in problem report #1702.
0415
0416 May 5, 2015 G.Cosmo
0417 - Fixed Coverity defect for unused variable quantity in G4Cons.
0418
0419 April 28, 2015 T.Nikitina geom-csg-V10-01-03
0420 - Fixed calculation of Normal in G4Para for kPX and kMX sides in
0421 DistanceToOut(p,v) and ApproxSurfaceNormal(p).
0422 Addressing problem report #1736.
0423
0424 March 3, 2015 G.Cosmo geom-csg-V10-01-02
0425 - Use accessors x(), y() and z() from UVector3, instead of directly accessing
0426 its data-members. Co-work with tag "geom-usolids-V10-01-09".
0427
0428 February 16, 2015 G.Cosmo geom-csg-V10-01-01
0429 - Fixed typo in copy-ctor and assignment operator for G4Tubs and G4OTubs.
0430
0431 December 5, 2014 G.Cosmo geom-csg-V10-01-00
0432 - Fix in temporary class G4OTubs to include symbol in library in any case.
0433
0434 September 17, 2014 G.Cosmo geom-csg-V10-00-06
0435 - Added wrapper for UTrap shape; adapted switch to original G4Trap accordingly.
0436 Requires tag "geom-usolids-V10-00-16".
0437
0438 September 4, 2014 T.Nikitina geom-csg-V10-00-05
0439 - G4Cons: fixed typo error in GetPointOnSurface() in the call
0440 to GetRadiusInRing(). Responsible for occasionally wrong reports
0441 when checking for overlaps.
0442 - G4Cons: fix in DistanceToIn(p,v) for points on the Surface, to resolve
0443 error reported in unit testing by the OpticalEscape test.
0444
0445 September 1, 2014 G.Cosmo geom-csg-V10-00-04
0446 - Fixed use of polyhedron pointer, to avoid race condition in MT
0447 when parameterised volumes are visualised.
0448
0449 March 5, 2014 G.Cosmo geom-csg-V10-00-03
0450 - Fixed proper handling of polyhedron pointer in solids, to avoid memory
0451 leak for visualization of parameterised volumes.
0452
0453 February 12, 2014 G.Cosmo geom-csg-V10-00-02
0454 - Simply reset polyhedron pointer to zero for modifiers of G4U* wrappers
0455 in parameterisation. Resolves crash in MT visualization when using USolids.
0456
0457 February 12, 2014 G.Cosmo geom-csg-V10-00-01 (and -00)
0458 - Added correct cloning mechanism in G4U* wrappers.
0459 Addressing problem report #1553.
0460
0461 November 22, 2013 G.Cosmo geom-csg-V09-06-09
0462 - Correction to USolids wrappers for proper setting of name to base class.
0463
0464 November 20, 2013 T.Mikitina geom-csg-V09-06-08
0465 - Fixed Coverity defects to USolids wrappers.
0466
0467 November 14, 2013 T.Nikitina geom-csg-V09-06-07
0468 - Corrections to G4U* wrappers to allow for visualization of parameterisations.
0469
0470 November 7, 2013 G.Cosmo geom-csg-V09-06-06
0471 - Moved wrappers from usolids module.
0472 Fixed internal dispatcher method for parameterisation in all wrappers.
0473 - Added switching mechanism for G4Box, G4Cons, G4Orb, G4Sphere, G4Trd
0474 and G4Tubs.
0475 - Defined temporary class G4OTubs to be used internally by G4CutTubs,
0476 in provision to have UCutTubs in the USolids library.
0477
0478 November 6, 2013 G.Cosmo geom-csg-V09-06-05
0479 - Added switch mechanism for USolids (box, cons, orb, sphere, trd, tubs).
0480 Renamed related G4 types to 'G4O'.
0481 - Moved wrappers from USolids module.
0482
0483 October 2, 2013 G.Cosmo geom-csg-V09-06-04
0484 - Correctly initialise fSPhi to zero in G4Sphere constructor.
0485
0486 August 14, 2013 G.Cosmo geom-csg-V09-06-03
0487 - Move function-scoped 'static const' values for half-tolerances to private
0488 data members of classes, to overcome false-positive race-conditions defects
0489 reported by Valgrind in MT mode.
0490 - Corrected sanity check for wrong/small dimensions in G4Box constructor.
0491
0492 April 16, 2013 T.Nikitina geom-csg-V09-06-02
0493 - Fix in G4Cons::DistanceToIn(p,v) for initialisation of dRmax for the
0494 case of shape with Rmin1=Rmax1=0.
0495
0496 December 14, 2012 G.Cosmo geom-csg-V09-06-01
0497 - Restored SVN id headers.
0498
0499 Dec 02, 2012 J.Allison geom-csg-V09-06-00
0500 - Removed NURBS.
0501
0502 Nov 14, 2012 P. Mato geom-csg-V09-05-09
0503 - Added #undef NDEBUG in unit tests to ensure that assert always works
0504
0505 Oct 19, 2012 G.Cosmo geom-csg-V09-05-08
0506 - G4Torus: include printout within G4CSGDEBUG. Some code formatting...
0507
0508 Oct 11, 2012 J.Apostolakis geom-csg-V09-05-07
0509 - G4Torus: small additional changes, to reorder a few computation
0510 for better FP accuracy.
0511
0512 Oct 4, 2012 J.Apostolakis geom-csg-V09-05-06
0513 - G4Torus: revised the values of delta, to account for precision loss
0514 in calculating radius 'pt'.
0515 Added printing in case of not finding normal when on surface.
0516
0517 Oct 3, 2012 J.Apostolakis geom-csg-V09-05-05
0518 - G4Para::SurfaceNormal(): fixed calculation of sin(alpha) from cosine
0519 and tangent.
0520
0521 June 12, 2012 G.Cosmo geom-csg-V09-05-04
0522 - Explicitly use inclusion of headers for system of units and physical
0523 constants, in plan to remove implicit inclusion from globals.hh.
0524
0525 May 14, 2012 G.Cosmo geom-csg-V09-05-03
0526 - Fixed spurious cases of hidden variable visibility, detected with
0527 '-Wshadow' compilation option on gcc compiler.
0528
0529 May 4, 2012 G.Cosmo geom-csg-V09-05-02
0530 - Restored G4CSGSolid::GetRadiusInRing() to non-inline to avoid propagating
0531 dependency on random generators.
0532
0533 May 3, 2012 G.Cosmo geom-csg-V09-05-01
0534 - Made utility method GetRadiusInRing() inline and corrected implementation.
0535
0536 April 6, 2012 M.Kelsey geom-csg-V09-05-00
0537 - Modified GetPointOnSurface() methods for solids using polar coordinate
0538 parametrizations, to generate more uniform distributions, using a
0539 function to generate proper radial coordinate included in G4CSGSolid.
0540
0541 November 15, 2011 G.Cosmo geom-csg-V09-04-11
0542 - Correction in G4CutTubs for missing implementation of GetCubicVolume()
0543 and GetSurfaceArea() utility methods, to be temporarly replaced by
0544 default G4VSolid implementation.
0545
0546 November 2, 2011 G.Cosmo geom-csg-V09-04-10
0547 - Removed declaration of methods not implemented in G4CutTubs and included
0548 by mistake.
0549
0550 October 31, 2011 T.Nikitina geom-csg-V09-04-09
0551 - First implementation of G4CutTubs solid, a tube with possible cuts in +-Z.
0552
0553 October 6, 2011 G.Cosmo geom-csg-V09-04-08, geom-csg-V09-04-07
0554 - Fixed Coverity defect for uninitialised static data in G4Sphere.
0555
0556 October 3, 2011 G.Cosmo geom-csg-V09-04-06
0557 - Fix in G4Sphere for setting of relative radial tolerances when setters
0558 for radiuses are explicitely called.
0559 - Relaxed validity condition in construction for the minimum size of the
0560 outer radius.
0561
0562 August 25, 2011 G.Cosmo geom-csg-V09-04-05
0563 - Migrated to new G4Exception scheme for warnings and errors.
0564 - Defined scheme for warnings/errors coding:
0565 + 1xxx for warnings, 0xxx for errors.
0566 Code numbering:
0567 + 0001: not supported or implemented features;
0568 + 0002: invalid setup/construct;
0569 + 0003: invalid run condition;
0570 + 1001: incorrect setup; automatically adapted.
0571 + 1002: notification.
0572
0573 June 1, 2011 G.Cosmo geom-csg-V09-04-04
0574 - Made radial tolerance a local constant instead of a static data member
0575 in G4Orb and G4Sphere.
0576
0577 May 27, 2011 T.Nikitina geom-csg-V09-04-03
0578 - G4Tubs: use safe formula for quadratic equation solution, in order to avoid
0579 numerical errors.
0580 - G4Torus: use relative radial tolerances to avoid loss of precision issues
0581 for shapes of big dimensions. Addresses problem report #1175.
0582
0583 May 12, 2011 G.Cosmo geom-csg-V09-04-02
0584 - Fixed compilation warnings from gcc-4.6.0 for variables set but not used.
0585
0586 Apr 27, 2011 T.Nikitina geom-csg-V09-04-01
0587 - Added protection for potential negative argument to sqrt() in
0588 CalculateExtent() for G4Orb, G4Cons and G4Sphere.
0589
0590 Jan 7, 2011 T.Nikitina geom-csg-V09-04-00
0591 - G4Cons: fix in DistanceToIn(p,v,..) to squared tolerance in comparision.
0592 Replaced calculation of the solution for the quadratic equation, to use safe
0593 formula, in order to avoid numerical errors when b is almost equal to sqrt(d).
0594 Addresses problem report #1153.
0595
0596 Nov 23, 2010 G.Cosmo geom-csg-V09-03-14 & V09-03-12
0597 - Fixed one left cases of cout precision restoring in G4Sphere.
0598
0599 Oct 19, 2010 G.Cosmo geom-csg-V09-03-11
0600 - Implemented Clone() virtual method for all solids, returning a pointer to a
0601 dynamically allocated copy of the solid. To be used by Geant4-MT.
0602
0603 Sep 23, 2010 G.Cosmo geom-csg-V09-03-10
0604 - Initialize fpPolyhedron to zero in G4CSGSolid copy-ctor and operator=().
0605
0606 Sep 22, 2010 G.Cosmo geom-csg-V09-03-09
0607 - Relaxed checking condition on SetOuterRadius() method to avoid
0608 restrictions in order of calls for modifiers.
0609
0610 Sep 17, 2010 G.Cosmo geom-csg-V09-03-08
0611 - Implemented copy-constructor and assignment operator for all solids
0612 to facilitate conversion to Geant4-MT.
0613
0614 Sep 17, 2010 G.Cosmo geom-csg-V09-03-07
0615 - Added missing validity checks on radii to modifiers in G4Tubs.
0616
0617 Sep 07, 2010 G.Cosmo geom-csg-V09-03-06
0618 - Fix within G4CSGDEBUG code for restoring cout precision.
0619
0620 Aug 23, 2010 G.Cosmo geom-csg-V09-03-05
0621 - G4Cons: fixed trivial compilation warning on Linux.
0622
0623 Aug 19, 2010 T.Nikitina geom-csg-V09-03-04
0624 - G4Torus: fix in DistanceToOut(p,v,...) to address problem report #1081.
0625
0626 Jul 12, 2010 G.Cosmo geom-csg-V09-03-03
0627 - Fixed condition in G4Tubs::Inside(p) for point on surface (T.Nikitina).
0628 - Corrected use of std::fabs() in place of std::abs() in G4Tubs, G4Cons,
0629 G4Sphere and G4Torus. Use pre-computed half-tolerance constants in G4Torus.
0630
0631 Jul 08, 2010 G.Cosmo geom-csg-V09-03-02
0632 - Improved initialisation logic in constructor for: G4Box, G4Cons, G4Orb,
0633 G4Para, G4Sphere, G4Torus, G4Trap, G4Trd, G4Tubs.
0634 - Corrected cases of not-restored cout precision in: G4Box, G4Cons, G4Orb,
0635 G4Para, G4Torus, G4Trap, G4Tubs.
0636 - G4Torus: fixed call to internal method for finding roots, to avoid copy
0637 of sdt::vector() by parameters. Some cleanup to avoid unnecessary protected
0638 section and virtual table.
0639 - Updated unit test for G4Sphere (V.Grichine).
0640
0641 May 25, 2010 G.Cosmo geom-csg-V09-03-01
0642 - G4Box: more minor fixes in coding style, following code review discussion.
0643
0644 May 18, 2010 G.Cosmo geom-csg-V09-03-00
0645 - G4Box: first implementation of speed improvements and corrections from joint
0646 code review of G4Box class: introduced half-tolerance constants and better
0647 logic in some conditional statements.
0648 - Some code cleanup.
0649
0650 Dec 04, 2009 V.Grichine
0651 - G4Orb: modified DistanceToIn(p,v) to be more consistent with Inside(p).
0652
0653 Nov 30, 2009 V.Grichine geom-csg-V09-02-08
0654 - G4Orb: moved debug warning in DistanceToIn(p,v) within G4CSGDEBUG flag.
0655
0656 Nov 26, 2009 T.Nikitina geom-csg-V09-02-07
0657 - G4Torus: fix in SolveNumericJT() in order to take in account the difference
0658 in the value of theta for different intervals, [0:pi] or [-pi:0], and for
0659 SPhi in [0:twopi] or [-twopi:0]. Addresses problem report #1086.
0660
0661 Nov 12, 2009 T.Nikitina geom-csg-V09-02-06
0662 - G4Cons: fix to DistanceToIn(p,v), added a check on the direction in case
0663 of point on surface. Fixes a problem of stuck tracks observed in CMS, due
0664 to wrong reply from the solid for points on the inner radius surface base
0665 with direction along the imaginary extension of the cone.
0666 - Added test case to internal test testG4Cons2.
0667
0668 Aug 07, 2009 T.Nikitina geom-csg-V09-02-05
0669 - G4Sphere: fix for the calculation of the normal in DistanceToOut()
0670 to avoid cases of division by zero in specific configurations.
0671 Addresses problem report #977.
0672
0673 Jun 30, 2009 T.Nikitina geom-csg-V09-02-04
0674 - Introduced to DistanceToIn(p,v) splitting of the distance for point very far
0675 from intersection area and big difference between solid dimensions and
0676 distance to it; resolves issue observed on 64 bits problem. Affected solids:
0677 G4Tubs, G4Cons, G4Sphere, G4Orb. Addresses problem report #1022.
0678 - Fixed rare cases of NaN on G4Sphere.
0679
0680 Jun 09, 2009 G.Cosmo geom-csg-V09-02-03
0681 - Fixed case of non-initialised start-Phi value in G4Tubs and G4Cons,
0682 problem introduced following modifications in tag "geom-csg-V09-02-00".
0683
0684 May 14, 2009 T.Nikitina geom-csg-V09-02-02
0685 - G4Sphere: initialise flags for full sphere in constructor.
0686
0687 May 14, 2009 T.Nikitina geom-csg-V09-02-01
0688 - G4Sphere: correction di DistanceToOut(p,v, ...) for phi sections for
0689 rays passing though zero.
0690 - More minor refiniments to G4Sphere following review.
0691
0692 May 08, 2009 G.Cosmo geom-csg-V09-02-00
0693 - G4Sphere: implemented speed improvements and corrections from joint
0694 code review of G4Sphere class. Cached computation for half-tolerances
0695 and use of Boolean flag for identifying if full-sphere, shell or section.
0696 Implemented caching of trigonometric values, now directly computed inside
0697 modifiers for Phi and Theta angles as required for parametrised cases.
0698 Rationalised usage of relative radial tolerances.
0699 - G4Tubs, G4Cons: rationalised usage of modifiers for Phi angles and
0700 simplified constructors.
0701 - Added new test case for relatively big spheres in unit tests testG4Orb
0702 and testG4Sphere, based on problem report #1046.
0703
0704 Nov 21, 2008 G.Cosmo geom-csg-V09-01-08
0705 - G4Sphere: defined Get/SetInnerRadius() accessors to be compliant with
0706 other CSG solids and allow consistent treatment in persistency code...
0707
0708 Nov 06, 2008 G.Cosmo geom-csg-V09-01-07
0709 - G4Tubs, G4Cons: implemented caching of trigonometric values, now directly
0710 computed inside modifiers for Phi angles and required for parametrised
0711 cases. Improvement bringing up to 20% speedup in normal tracking for
0712 tube/cone-sections placements.
0713
0714 Nov 05, 2008 G.Cosmo geom-csg-V09-01-06
0715 - G4Cons: implemented first speed improvements and corrections from joint
0716 code review of G4Cons class. Cached computation for half-tolerance and
0717 use of Boolean flag for identifying if full-cone or section.
0718 - G4Tubs: more refinements to previous review; corrected implementation
0719 of constructor to conform to implementation as in G4Cons. Fixed issue in
0720 SetDeltaPhi() method after changes introduced in the previous tag.
0721
0722 Sep 18, 2008 T.Nikitina geom-csg-V09-01-05
0723 - G4Tubs: implemented first speed improvements and corrections from joint
0724 code review of G4Tubs class. Cached computation for half-tolerance and
0725 use of Boolean flag for identifying if full-tube or section.
0726
0727 Jul 07, 2008 V.Grichine geom-csg-V09-01-04
0728 - G4Sphere: fixed bug in DistanceToOut(p, v, ...) for normal 'fSTheta'
0729 greater than 90*deg, and use of tangent giving negative value.
0730 Completes series of corrections introduced in previous tag.
0731
0732 Jun 23, 2008 T.Nikitina geom-csg-V09-01-03
0733 - G4Tubs: fix in DistanceToIn(p,v, ...) in case of point on surface with
0734 very small tangent direction; now returning kInfinity and no longer zero.
0735 It fixes rare observed cases of zero value returned by both DistanceToIn()
0736 and DistanceToOut(), causing stuck tracks with zero step length.
0737
0738 Jun 20, 2008 V.Grichine
0739 - G4Sphere: fixed calculation of roots in DistanceToOut(p,v,...) for
0740 theta-conical surfaces interserctions and for sTheta<=90 degree intersection.
0741 Addresses issue reported when running PET application with optical photons
0742 about mis-computation of distance on half-sphere constructs.
0743 - Updated unit test for sphere.
0744
0745 Apr 22, 2008 V.Grichine geom-csg-V09-01-02
0746 - G4Trap: corrections for arithmetic operations in 8-point constructor.
0747 Addressing problem report #934.
0748
0749 Mar 13, 2008 G.Cosmo geom-csg-V09-01-01
0750 - Cleared compilation warnings in G4Sphere on gcc-4.3.0 for
0751 ambiguous use of parentheses in condition statements.
0752
0753 Feb 20, 2008 T.Nikitina geom-csg-V09-01-00
0754 - G4Cons:
0755 o Added protection against NaN in GetPointOnSurface() in the case the
0756 check is run for Rmax1==Rmax2.
0757
0758 Nov 23, 2007 T.Nikitina geom-csg-V09-00-02
0759 - Fixed problem of undefined side for valid surface normal in case of Phi
0760 section and direction through the center of either A G4Tubs or G4Cons shape.
0761
0762 Oct 2, 2007 T.Nikitina geom-csg-V09-00-01
0763 - G4Torus:
0764 o Fixed bug in CalculateExtent() for case of non-rotated full-phi
0765 torus definition: added protection against negative value for sqrt()
0766 and corrected formula for 'delta'. Fixes problem of NaN detected in
0767 initialisation by CMS.
0768 o Fixed bug in SolveNumericJT(): corrected handling of complex roots,
0769 'rootsrefined' is used only if the number of refined roots is the same
0770 as for primary roots. Addresses problem report #969.
0771
0772 Aug 16, 2007 T.Nikitina geom-csg-V09-00-00
0773 - G4Tubs: fixed bug in DistanceToOut(p,v,..) for negative value under sqrt()
0774 for the case of point p on the surface and v tangent to the surface.
0775 Responsible for rare cases of NaN.
0776
0777 May 18, 2007 G.Cosmo geom-csg-V08-03-01
0778 - Use kAngTolerance and kRadTolerance from G4GeometryTolerance class.
0779 - Coworks with tag "global-V08-03-03".
0780
0781 May 16, 2007 T.Nikitina geom-csg-V08-03-00
0782 - G4Tubs: fixed bug for DistanceToOut(p,v) for phi section.
0783 Bug was causing segmentation fault in recursive_test (problem report #784).
0784 For v crossing the center of the tub DistanceToOut was always giving
0785 Radial distance and not distance in Phi.
0786 - G4Cons: fixed bug for DistanceToOut(p,v) for phi section,
0787 the same as for G4Tubs.
0788 - Updated unit tests.
0789
0790 Oct 19, 2006 G.Cosmo geom-csg-V08-01-00
0791 - Added explicit computation for GetSurfaceArea() for all solids
0792 (by H.Dierckx).
0793 - Implemented caching mechanism for computation of surface area in
0794 G4CSGSolid, as done for the geometrical volume computation.
0795
0796 Jun 06, 2006 V.Grichine geom-csg-V08-00-01
0797 - G4Tubs: added protection against NaNs in CalculateExtent() to avoid
0798 sqrt() of negative numbers due to round-off.
0799 - Updated unit tests testG4Sphere and testDistanceAccuracy.
0800
0801 Jan 16, 2006 V.Grichine geom-csg-V08-00-00
0802 - G4Sphere: fixed bug in DistanceToOut() for theta intersections.
0803
0804 Nov 20, 2005 V.Grichine geom-csg-V07-01-05
0805 - G4Torus: fixed bug in Inside(p) for phi sections.
0806 Fixes problem report #810.
0807
0808 Nov 9, 2005 G.Cosmo geom-csg-V07-01-04
0809 - Added fake default constructor for all concrete solids and relevant
0810 utility classes, for usage of direct object persistency.
0811 - Implemented changes to support CLHEP-2.0.X for explicit usage of the
0812 CLHEP/HepGeom namespaces for CLHEP types.
0813
0814 Oct 23, 2005 V.Grichine geom-csg-V07-01-03
0815 - G4Para: fixed bug in DistanceToOut(p,v) for the case v.x()<0.
0816 Following problem report from user posted on Hypernews (#452).
0817
0818 Sep 5, 2005 O.Link geom-csg-V07-01-02
0819 - Moved implementation for DistanceToIn/Out() in G4Torus to make use of
0820 G4JTPolynomialSolver for precise calculation of the intersections.
0821 - Reviewed unit tests and reduced statistics.
0822
0823 Aug 8, 2005 D.Anninos geom-csg-V07-01-01
0824 - Added GetPointOnSurface() to all solids. The method returns a random
0825 point according to a quasi-uniform distribution along the surface.
0826
0827 Jul 25, 2005 O.Link geom-csg-V07-01-00
0828 - Fixed bug in G4Sphere::DistanceToOut(p,v):
0829 added check for intersection with double cone.
0830 - Added new unit test testDistanceAccuracy (V.Grichine).
0831
0832 Jun 8, 2005 V.Grichine geom-csg-V07-00-09
0833 - Keep old specification for SurfaceNormal() to treat usage of the
0834 function for points not at the surface.
0835
0836 Jun 6, 2005 V.Grichine geom-csg-V07-00-08
0837 - Correction to SurfaceNormal() for G4Cons, G4Sphere, G4Torus, G4Tubs
0838 for properly handling location on z-axis and in the frame origin.
0839 Fixed bug in G4Cons::SurfaceNormal(p) for normals returned from
0840 rmax and rmin.
0841 - Moved debug printouts for surface-normals to G4CSGDEBUG.
0842 - Cleared compilation warnings in unit tests and updates.
0843
0844 May 27, 2005 J.Allison geom-csg-V07-00-07
0845 - Fixed polyhedron representation of G4Torus.
0846
0847 May 26, 2005 G.Cosmo geom-csg-V07-00-06
0848 - G4Box.cc: restored call to AddSolid() and replaced old AddThis() in
0849 DescribeYourselfTo().
0850
0851 May 11, 2005 V.Grichine geom-csg-V07-00-05
0852 - G4Para: bug fixed in SurfaceNormal(p) for x-distance, to be now in
0853 accordance with the surface selection using Inside(p).
0854 - Updated unit test testSurfaceNormal.cc.
0855
0856 May 09, 2005 V.Grichine geom-csg-V07-00-04
0857 - Updated implementation of SurfaceNormal(p) to get consistence with
0858 Inside(p) functions for the treatment of phi/theta surfaces.
0859 They are treated now in both functions in terms of kAngTolerance.
0860 The reason is that historically SurfaceNormal(p) was using only
0861 kCarTolerance for estimation of shortest distance to a surface. Now,
0862 following the new updated specification, the surface selection is made
0863 according to Inside(p) approach (as kSurface is selected), i.e. - for
0864 phi/theta surfaces in terms of kAngTolerance.
0865
0866 Apr 26, 2005 V.Grichine, J.Apostolakis
0867 - Simplified and revised the new implementation for SurfaceNormal(p)
0868 with edges/vertices and made becoming the default one for all solids.
0869
0870 Apr 20, 2005 V.Grichine geom-csg-V07-00-03
0871 - G4Trap: fix in p.x() centering to sum over all vertices.
0872
0873 Mar 23, 2005 J.Allison geom-csg-V07-00-02
0874 - Added test for Number-Of-Rotation-Steps in G4CSGSolid::GetPolyhedron().
0875 Requires tag "greps-V07-00-02".
0876
0877 Mar 03, 2005 J.Allison geom-csg-V07-00-01
0878 - Changed AddThis() with AddSolid() for all solids in DescribeYourselfTo()
0879 implementation.
0880
0881 Dec 02, 2004 V.Grichine geom-csg-V07-00-00
0882 - New alternative implementation of SurfaceNormal(p) with edges/vertices
0883 for G4Box, G4Para, G4Trap, G4Trd. Old implementation is still the default.
0884 Can be activated by setting G4NEW_SURF_NORMAL variable before compilation.
0885
0886 Nov 15, 2004 V.Grichine geom-csg-V06-02-06
0887 - G4Trap: added check for X-centering for constructor by verteces.
0888 Fixes problem report #687.
0889 - New unit test for surface-normal and updated unit tests for sphere
0890 and trap.
0891
0892 Oct 10, 2004 J.Allison geom-csg-V06-02-05
0893 - Added GetPolyhedron, a smart access function that creates a G4Polyhedron
0894 on request and stores for future access. A null pointer means "not
0895 available".
0896
0897 Sep 22, 2004 V.Grichine geom-csg-V06-02-04
0898 - Added specific implementation of GetCubicVolume() for all CSG solids.
0899 The method compute the exact geometrical values and stores it.
0900 The value is reset each time a parameter of the solid is modified.
0901 - Moved inline methods for G4Orb to .icc file.
0902 - Added unit test testSurfaceInOut.cc.
0903
0904 Sep 16, 2004 V.Grichine geom-csg-V06-02-03
0905 - Bug fix in G4Sphere::SurfaceNormal(p) for theta normals.
0906
0907 Jul 28, 2004 V.Grichine geom-csg-V06-02-02
0908 - Fix in G4Cons::DistanceToIn(p,v) on fRmax surface and move in,
0909 the condition became a bit more strict && determinant >=0, i.e.
0910 intersections in addition to go in.
0911 Fixes a rare problem of dIn=dOut=0 observed in 3 events over a
0912 statistics of 10^8..
0913 - Updated unit test testSurfaceInOut.cc to consider the test-case above.
0914
0915 Jul 16, 2004 V.Grichine geom-csg-V06-02-01
0916 - Fix in G4Sphere::DistanceToOut(p,v,...) on fRmin moving outside.
0917 The bug showed 3 events of dIn=dOut=0 for 10^7 statistics in
0918 testSurfaceInOut.
0919 - Added new unit test testSurfaceInOut.cc.
0920
0921 Jul 02, 2004 V.Grichine geom-csg-V06-02-00
0922 - Fixes curing rare conditions of loops at boundaries for G4Orb and G4Sphere:
0923 o G4Orb.cc: bug fix in DistanceToIn(p,v) on fRmax surface allowing
0924 move near fRmax-fCarTolerance/2.
0925 o G4Sphere.cc: bug fix in DistanceToIn(p,v) on Rmax/min surface for
0926 condition of intersection with (Rmax/min-kCarTolerance) artificial
0927 surface.
0928 - Updated unit test for G4Orb.
0929
0930 Mar 18, 2004 V.Grichine geom-csg-V06-00-01
0931 - G4Torus.cc: bug fix in Inside(p) fixing warnings reported in
0932 debug-mode of 'point p is outside'.
0933
0934 Jan 26, 2004 V.Grichine geom-csg-V06-00-00
0935 - Converted strong exceptions in warning notifications for rare anomalous
0936 conditions in DistanceToOut(p,v,..).
0937 - G4Cons.cc: bug fix in DistanceToIn(p,v) to resolve situations of calls
0938 to DistanceToOut() for points outside.
0939
0940 Dec 4, 2003 V.Grichine geom-csg-V05-02-06
0941 - G4Trap.cc: fixed initialisation of planes in default constructor.
0942 - Added new unit test for G4Sphere and new test case for G4Cons.
0943
0944 Nov 5, 2003 V.Grichine geom-csg-V05-02-05
0945 - G4Orb[.hh.cc]: introduced relative tolerance accuracy on fRmax surface
0946 in all methods.
0947
0948 Nov 3, 2003 G.Cosmo geom-csg-V05-02-04
0949 - Code cleanup and headers inclusion review
0950 (replaced by forward declarations where necessary).
0951
0952 Nov 2, 2003 V.Grichine
0953 - G4Sphere, G4Orb: revision of algorithm for Phi sections in
0954 method Inside().
0955
0956 Oct 29, 2003 J.Apostolakis geom-csg-V05-02-03
0957 - G4Sphere.cc: fix for in Inside() for a point with Phi angle:
0958 0.5 kAngTol < phi < Phi_start
0959
0960 Oct 28, 2003 G.Cosmo geom-csg-V05-02-02
0961 - Migrated to new G4Exception scheme.
0962
0963 Oct 09, 2003 V.Grichine geom-csg-V05-02-01
0964 - Initialise safe=0.0 in DistanceToIn/Out(p) in all solids.
0965 - Introduced G4Orb solid: a simple sphere with only outer radius.
0966
0967 Sep 30, 2003 G.Cosmo geom-csg-V05-02-00
0968 - Updated GNUmakefile for unit tests, according to new structure
0969 introduced in "geometry-V05-02-00".
0970
0971 Jun 25, 2003 G.Folger geom-csg-V05-01-00
0972 - Added disclaimer of liability where needed.
0973
0974 Feb 03, 2003 G.Cosmo geom-csg-V05-00-00
0975 - G4Cons.cc: enhanced treatment of phi-sections,
0976 according to algorithm used also in G4Tubs (V.Grichine).
0977 - Updated unit tests.
0978
0979 Oct 28, 2002 G.Cosmo geom-csg-V04-01-01
0980 - Added implementation of StreamInfo() to comply with new interface for
0981 G4VSolid in "geommng-V04-01-03".
0982 - Moved inline functions to .icc files, reorganised comments for the Software
0983 Reference Manual.
0984 - Some cosmetic changes to code formatting, removed all <TAB> characters and
0985 adopted uniform code indentation.
0986 - Extended unit tests for G4Cons and G4Sphere (V.Grichine).
0987
0988 Jun 26, 2002 V.Grichine geom-csg-V04-01-00
0989 - G4Cons.cc: bug fixed in DistanceToIn(p,v) concerning z-crossing at the
0990 edge with Rmin,Rmax.
0991
0992 Jun 19, 2002 V.Grichine geom-csg-V04-00-05
0993 - G4Sphere.cc: bug fixed in Inside() for treatment of point p on z-axis.
0994 Added new condition [(rho2 || p.z()) && fDTheta < M_PI - kAngTolerance*0.5)]
0995 for treating special case. Fixes problem report #378.
0996
0997 May 15, 2002 G.Cosmo geom-csg-V04-00-04
0998 - G4Trap.cc, G4Tubs.cc: changed local enum 'kUndefined' to 'kUndef',
0999 to co-work with tag "global-V04-00-06", where 'kUndefined' is now
1000 defined for EAxis.
1001
1002 Apr 16, 2002 V.Grichine geom-csg-V04-00-03
1003 - G4Tubs.cc: restored "vertices" algorithm for CalculateExtent() which
1004 was temporarly disabled (see reference to tag geom-solids-csg-V03-00-03).
1005 - Updated unit test for G4Tubs, testG4Tubs.cc.
1006
1007 Feb 15, 2002 V.Grichine geom-csg-V04-00-02
1008 - G4Para.cc: fixed bug in G4Para::Inside() in calculation of xt,
1009 according to problem report #357.
1010
1011 Jan 31, 2002 V.Grichine geom-csg-V04-00-01
1012 - G4Sphere.cc: bug fix in Inside() function.
1013 Fix problem report #216.
1014 - Updated unit test for G4Sphere.
1015
1016 Jan 10, 2002 G.Cosmo geom-solids-csg-V04-00-00
1017 - Moved all verbosity mode warnings to G4CSGDEBUG and commented exceptions.
1018 - Activated G4CSGDEBUG mechanism in GNUmakefile.
1019 - G4Sphere.cc: fixed a problem with tolerances in the case of large Radius.
1020 The case (test18) involves an Rmax = 250 000 000.00 mm
1021 The ratio -9
1022 tolerance 1.0 10 -17
1023 ----------- = ------------ = 0.4 10
1024 Rmax +8
1025 2.5 10
1026 which is smaller than the precision of doubles.
1027 Solution (for DistanceToOut(), where problem occured):
1028 use a flexible tolerance, equal to the maximum of (kRadTolerance, 10 * R )
1029 (J.Apostolakis).
1030 - Upgraded unit tests and fixed warnings on gcc-2.95-2.
1031
1032 Aug 27, 2001 V.Grichine geom-solids-csg-V03-02-00
1033 - G4Sphere.cc: bug fixed in G4Sphere::SurfaceNormal for the case kNETheta.
1034 Fixes problem report #290.
1035
1036 May 18, 2001 G.Cosmo geom-solids-csg-V03-01-02
1037 - Added G4CSGDEBUG preprocessor flag to discriminate for debug verbosity
1038 specific to CSG solids. Included in G4Exception of DistanceToOut() for
1039 "point p is outside" in G4Box, G4Cons, G4Tubs.
1040
1041 Apr 20, 2001 G.Cosmo geom-solids-csg-V03-01-01
1042 - Updates for migration to STL vector.
1043 Modified files: G4Box.cc, G4Cons.cc, G4Para.cc, G4Sphere.cc,
1044 G4Torus.cc, G4Trap.cc, G4Trd.cc, G4Tubs.cc.
1045 Require coworking with the rest of geometry-V03-01-00.
1046
1047 Apr 18, 01 V. Grichine geom-solids-csg-V03-01-00
1048 - G4Trap.cc:
1049 o Fixed memory leak in CalculateExtent() for creation of vertices in
1050 case of finite rotation. (courtesy of D.Williams)
1051 o Removed useless inclusion of math.h.
1052
1053 Feb 21, 01 V. Grichine geom-solids-csg-V03-00-03
1054 - G4Tubs.cc:
1055 o Fixed bug in function Inside(p) in computation of pPhi
1056 for points at phi = 0 if the (start phi)+(delta phi) is at phi = 0.
1057 o Temporarly modified CalculateExtent(...), now simply based on
1058 G4Box::CalculateExtent(...). Updated unit test testG4Tubs.cc.
1059
1060 Feb 01, 01 V. Grichine geom-solids-csg-V03-00-02
1061 - G4Box: introduced checks against negative (or <2*kCarTolerance) dimensions
1062 in methods SetXHalfLength(), SetYHalfLength() and SetZHalfLength().
1063
1064 Jan 29, 00 G. Cosmo geom-solids-csg-V03-00-01
1065 - G4Box: introduced fixes to algorithm for computation of rotated vertices
1066 in CalculateExtent() as previously committed in tag geom-solids-csg-V02-00-10.
1067 - G4Torus: extracted logic for G4PolynomialSolver now included in
1068 global/HEPNumerics. Coworks with tag global-V03-00-02.
1069 - Added dependency to global/HEPNumerics in GNUmakefile.
1070
1071 Jan 18, 00 V. Grichine geom-solids-csg-V03-00-00
1072 - Fixed condition from (pPhi<0) to (pPhi<-0.5*kAngleTolerance) in
1073 G4Tubs::Inside(p). Fixes problem report #198.
1074
1075 Dec 07, 00 V. Grichine geom-solids-csg-V02-00-14
1076 - G4Tubs.cc: corrections in phi-section algorithm of Inside(p).
1077
1078 Dec 01, 00 G. Cosmo geom-solids-csg-V02-00-13
1079 - Increased basic number of iterations from 8 to 12 for Newton algorithm
1080 in G4Torus.cc to assure root retrivial.
1081
1082 Nov 28, 00 V. Grichine geom-solids-csg-V02-00-12
1083 - Bug fixed in G4Tubs::Inside(p) for analysis of phi positioning when
1084 on +-fDz surface.
1085
1086 Nov 20, 00 G. Cosmo geom-solids-csg-V02-00-11
1087 - Fixes to remove warnings from "-Wall -ansi -pedantic" g++ compiler options:
1088 o commented out variables declared and not used.
1089 o fixed declaration of variables used before being initialised.
1090 o fixed order of initialisation of member data in constructors.
1091 o fixed usage of unsigned-int (size_t) for array indeces.
1092 - NB: based on tag geom-solids-csg-V02-00-09.
1093
1094 Nov 16, 00 V. Grichine geom-solids-csg-V02-00-10
1095 - G4Box.cc: introduced fixes to algorithm for computation of rotated vertices
1096 in CalculateExtent(). (D.Williams)
1097
1098 Nov 10, 00 G. Cosmo geom-solids-csg-V02-00-09
1099 - G4Torus.cc: removed debug print-out which was still included by mistake
1100 in constructor.
1101
1102 Nov 02, 00 G. Cosmo geom-solids-csg-V02-00-08
1103 - QA code revision and cleanup (+fixes from CodeWizard filtering):
1104 o Removed virtual keyword from GetEntityType() concrete function.
1105 o General cosmetics.
1106
1107 Oct 31, 00 V. Grichine geom-solids-csg-V02-00-07
1108 - G4Tubs::DistanceToOut(p,v,...):
1109 o Initialised sr and sphi to kInfinity and re-introduced additional
1110 condition on check for Rmin intersection (t2 >= 0).
1111
1112 Oct 26, 00 G. Cosmo geom-solids-csg-V02-00-06
1113 - G4Cons::DistanceToOut(p,v): leave out warning if point is outside.
1114
1115 Oct 23, 00 G. Cosmo geom-solids-csg-V02-00-05
1116 - G4Tubs::DistanceToOut(p,v,...):
1117 o Still correction to thickness of conical surfaces. (V.Grichine)
1118 o Commented-out additional condition on check for Rmin intersection
1119 (t2 >= 0), recently introduced (roi2).
1120 Requires further investigation !!
1121 - G4Torus:
1122 o Introduced more stable numerical method (Newton-based) for computing
1123 roots of equations in DistanceToIn() and DistanceToOut(). (E.Medernach)
1124
1125 Oct 18, 00 V. Grichine geom-solids-csg-V02-00-04
1126 - G4Cons.cc, G4Tubs.cc:
1127 added check against negative distance returned by DistanceToIn/DistanceToOut.
1128 - G4Cons.cc:
1129 added correction for thickness of conical surfaces, remarkable for big
1130 opening angles, in DistanceToIn/DistanceToOut functions.
1131
1132 Oct 05, 00 V. Grichine geom-solids-csg-V02-00-03
1133 - G4Cons.cc:
1134 o fix in DistanceToIn(p,v): corrected condition on conical surface to
1135 consider a real projection of the conical surface thickness on XY
1136 plane (0.5*kCarTolerance*secRMin instead of 0.5*kCarTolerance), when
1137 dealing with cons with large opening angle.
1138 o Updated unit test testG4Cons2.cc.
1139
1140 Aug 16, 00 V. Grichine geom-solids-csg-V02-00-02
1141 - G4Cons.cc:
1142 o fix in constructor to check if one of the Rmin is equal to 0,
1143 if so, it will be set to 1e3*kRadTolerance.
1144 o Deactivated call to G4Exception in DistanceToOut(p) if p is outside,
1145 replaced by simple warning.
1146 - G4Tubes.cc, G4Box.cc:
1147 o Deactivated call to G4Exception in DistanceToOut(p) if p is outside,
1148 replaced by simple warning.
1149
1150 Aug 08, 00 V. Grichine geom-solids-csg-V02-00-01
1151 - G4Cons.cc, G4Tubs.cc:
1152 o fixes to DistanceToOut(p,v,...) to make roots of quadratic equations
1153 more stable.
1154 o added check if point is outside in G4Tubes::DistanceToOut(p),
1155 some code formatting.
1156
1157 Jul 27, 00 V. Grichine geom-solids-csg-V02-00-00
1158 - G4Cons.cc:
1159 o added more diagnostics in DistanceToOut(p)
1160 o cosmetics changes
1161 - Updated unit test for G4Cons.
1162
1163 Jun 22, 00 V. Grichine geom-solids-csg-V01-01-04
1164 - G4Box.cc:
1165 o added safety against call from outside in DistanceToOut(p)
1166 o added more diagnostics before exception in DistanceToOut(p,v,...)
1167 o cosmetics changes
1168 - G4Torus[.hh.cc]:
1169 o added new alternative functions SolveBiQuadratic/CubicNew.
1170 o fix in SolveBiQuadratic() for ambiguous expression in looping index
1171 detected by Insure++.
1172 - Updated unit tests testG4Torus and testG4Trd.
1173
1174 May 17, 00 V. Grichine geom-solids-csg-V01-01-03
1175
1176 - G4Tubs.cc:
1177 o introduced fix in DistanceToOut(p,v,...) in computation of xi, yi for
1178 (sphi >= -0.5*kCarTolerance). This fixes problem reports #76 and #91.
1179 o added more diagnostics in case of invalid enum for DistanceToOut.
1180 - Updated unit test for G4Tubs.
1181
1182 May 05, 00 V. Grichine geom-solids-csg-V01-01-02
1183
1184 - G4Box.cc, G4Trd.cc:
1185 o modified DistanceToIn(p,v) to return 0 distance in case computed
1186 value is less than 0.5*kCarTolerance.
1187 o Cosmetic changes.
1188 - Updated unit tests for G4Box and G4Trd.
1189
1190 Apr 11, 00 J. Allison
1191
1192 - Removed implementations of GetExtent in most sub-classes of G4VSolid (a
1193 default implementation exists in G4VSolid).
1194 - All implementations of DescribeYourselfTo (G4VGraphicsScene& scene) const
1195 now correctly written: scene.AddThis(*this).
1196
1197 Apr 05, 00 G. Cosmo geom-solids-csg-V01-01-01
1198 - G4Tubs.cc: fixed bug in function Inside(p).
1199 Removed (commented) in the code umproper addition of 2PI
1200 to Phi-angle particle (V.Grichine)
1201 - G4Hype[.hh.cc]: fixed several longstanding issues and bring methods
1202 into compliance with specifications (D.Williams)
1203 - Moved to "specific" the following classes:
1204 G4ClippablePolygon, G4EnclosingCylinder, G4Hype, G4PolyPhiFace,
1205 G4Polycone, G4PolyconeSide, G4Polyhedra, G4PolyhedraSide,
1206 G4ReduciblePolygon, G4IntersectingCone, G4SolidExtentList,
1207 G4VCSGface, G4VCSGfaceted.
1208 - Moved testG4Hype.cc and testG4Polycone.cc from CSG/test to
1209 specific/test
1210 - Moved generic tests "SBT" and "Fred" one level up to solids/test.
1211 - Organised class description comments for the Software Reference Manual
1212 in all headers.
1213
1214 Mar 23, 00 G. Cosmo geom-solids-csg-V01-01-00
1215 - Tagged.
1216
1217 Mar 22, 00 D. Williams
1218 - G4PolyhedraSide.cc: fixed bug in G4PolyhedraSide::Normal(...).
1219 The method Normal(...) (used by G4VCSGfaceted::SurfaceNormal) was not
1220 filling in the argument bestDistance. This fixes a bug observed in
1221 G4Polyhedra::SurfaceNormal.
1222
1223 Mar 14, 00 V. Grichine
1224 - Added diagnostics in G4Cons, G4Sphere and G4Torus in function
1225 DistanceToOut(p,v,...).
1226
1227 Mar 03, 00 G. Cosmo geom-solids-csg-V01-00-05
1228 - Minor fixes to unit tests to make them up-to-date with recent
1229 development versions (already included in tag geometry-V01-00-00a).
1230 - G4PolyconeSide.cc, G4PolyhedraSide.cc: added explicit cast to G4int
1231 to avoid warnings on Linux.
1232
1233 Jan 19, 00 G. Cosmo geom-solids-csg-01-00-04
1234 - Fixed bug in DistanceToIn(p,v). Modified files: G4Trap.cc and
1235 testG4Trap.cc. (V.Grichine)
1236 - Syncronized file versions with HEAD (essentially CVS headers changes).
1237 - Fixes for missing migration on HEAD related to some files in test/fred
1238 and test/SBT.
1239
1240 Nov 17, 99 J. Apostolakis geom-solids-csg-01-00-03
1241 - Tagged
1242
1243 Nov 17, 99 V. Grichine
1244 - Added initialisation to Eside "side" variable in DistanceToOut(p,v)
1245 in CSG solids --> Problem report from D.C. Williams, BaBar
1246 - A check in G4Trap Makeplane added.
1247
1248 Nov 10, 99 J. Apostolakis geom-solids-csg-01-00-02-cand
1249 - Included David Williams' modifications to
1250 G4IntersectingCone.cc, G4PolyconeSide.cc and G4VCSGfaceted.cc
1251 and to test/SBT/SBT.cc and test/SBT/polycone.geant4
1252
1253 Nov 10, 99 J. Apostolakis geom-solids-csg-01-00-01
1254 - Tagged
1255
1256 May 18, 99 David Williams
1257 - Replaced 1/DBL_MAX with DBL_MIN (valid correction, seen in tests for STL)
1258 in G4PolyPhiFace.cc, G4PolyconeSide.cc and G4PolyhedraSide.cc
1259
1260 Apr 29, 99 David Williams
1261 - G4Polyhedra and G4Polycone (and G4VCSGfaceted) modified:
1262 1. Implemented correct copy constructors and assignment operators.
1263 2. Fix some leaks for tracks that pass exactly through an edge.
1264 Some leaks still remain: particularly if a track passes through
1265 a corner and between the curved edges of G4Polycone.
1266 3. G4Polyhedra argument numSide changed to G4int (from G4double)
1267
1268 Apr 13, 99 Vladimir Grichine and Simone Giani
1269 - Minor consistency fix to 8 basic CSG solids:
1270 Tolerance used in calculation of extent but not in one place,
1271 and not another - this tripped up the client code.
1272
1273 Feb 16, 99 David Williams
1274 - Repaired bugs in G4Polycone (G4PolyconeSide.cc) as found in
1275 test/testG4Polycone and missed in below.
1276 - Updated definition of DistanceToIn(p) and DistanceToOut(p) to
1277 return zero when the point p is on the surface of the solid.
1278
1279 Feb 12, 99 David Williams
1280 - src/G4PolyconeSide.cc updated (revision 1.4) to fix a bug discovered by
1281 test/testG4Polycone.
1282
1283 Feb 9, 99 David C. Williams (davidw@scipp.ucsc.edu)
1284 - I've committed new versions of the CSG Polycone and Polyhedra in the
1285 geant4 repository, including a new utility class called
1286 G4ReduciblePolygon. The new versions fix several subtle bugs which my
1287 "test3" batch geometry testing code uncovered. In addition, the new class
1288 G4ReduciblePolygon is used to run strict tests on the validity of input
1289 parameters.
1290 To fix a bug in Polyhedra, I had to back out some fancy code that
1291 allowed it to calculate intersections at a speed that was independent of
1292 the number of sides. The new version now runs at a speed proportional to
1293 the number of sides, and is thus much slower for polyhedras with many
1294 sides. I can fix this, but I thought it would be best to get the bug fixes
1295 in as soon as possible.
1296
1297 Feb 10, 99 John Apostolakis
1298 - History file created.